Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributable errors #2519

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Attributable errors #2519

wants to merge 6 commits into from

Conversation

thomash-acinq
Copy link
Member

This is an implementation of the fat error proposal lightning/bolts#1044

@joostjager
Copy link

joostjager commented Dec 8, 2022

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 84.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
+ Coverage   85.84%   85.86%   +0.02%     
==========================================
  Files         216      217       +1     
  Lines       18158    18242      +84     
  Branches      760      798      +38     
==========================================
+ Hits        15588    15664      +76     
- Misses       2570     2578       +8     
Files Coverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala 100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala 100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala 95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala 95.90% <100.00%> (+0.03%) ⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala 90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala 100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala 97.33% <100.00%> (+0.03%) ⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala 80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala 89.13% <66.66%> (ø)
... and 6 more

... and 4 files with indirect coverage changes

This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants