Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tlv stream to onion failures #2455

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Add tlv stream to onion failures #2455

merged 4 commits into from
Jan 6, 2023

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Oct 11, 2022

Extend every onion failure with an optional tlv stream, as specified here: lightning/bolts#1021

I have verified cross-compatibility with lnd (lightningnetwork/lnd#6967) in both directions (reading and writing a tlv stream) and the spec PR has been merged, so this is ready to integrate.

t-bast referenced this pull request Nov 7, 2022
The specification recommends using a length of 256 for onion errors, but
it doesn't say that we should reject errors that use a different length.

We may want to start creating errors with a bigger length than 256 if we
need to transmit more data to the sender. In order to prepare for this,
we keep creating 256-bytes onion errors, but allow receiving errors of
arbitrary length.

See the specification here: lightning/bolts#1021

Fixes #2438
Extend every onion failure with an optional tlv stream.

See the specification here: lightning/bolts#1021
@t-bast t-bast marked this pull request as ready for review January 3, 2023 14:47
@t-bast t-bast requested a review from pm47 January 3, 2023 14:47
@t-bast t-bast requested a review from pm47 January 5, 2023 16:10
@t-bast t-bast merged commit c9c5638 into master Jan 6, 2023
@t-bast t-bast deleted the onion-error-tlv-stream branch January 6, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants