Adding parameters to optimizer automatically #526
+43
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#525
Current Behaviour
If a new parameter is added to the model, the parameters dont get trained. This is because currently only certain parameters are explicitly added to the optimiser. This is done to be able to add different weight decays for specific parameters.
Desired behaviour
When developing and adding new Modules with new parameters one expects these to be trained during training. Hence a function that automatically adds any parameters that don't have explicit optimisation parameters defined to be added to the optimiser with default settings.
Alternatives
Printing a warning