-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content to format_metadata, different_tools and help #25
Conversation
I also made quite a lot of changes to different tools trying to test a different formatting and a lot more content but I haven't pushed them yet, so I might try to merge your branch locally with mine, it might take sometime though |
Ah, sorry Paola :( Please feel free to override my changes where needed - or if it's not too disparate then you could accept this then merge. I suspect I've just caused you a pile of pain though, sorry I should have done it as multiple pull requests in hindsight :( |
In hindsight we should definitely do one pull request per page! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the braindump in format_metadata
I'm bad at maths - there's an error in format metadata where I estimate chunk size, it'll be out by a factor of 8 because I forgot that bits and bytes aren't the same thing :p so @chloemackallah that'll need to be fixed. I can do that on review but I'm not going to make any more edits until Paola's had a chance to deal with the mess I made her in the tools section. |
Then realised I can change that file without affecting @paolap so I've fixed that chunk size estimate. Thanks heaps for the review Chloe! :) |
DO NOT MERGE THIS PULL REQUEST!!! |
I think I can merge this one too now. Apologies for the mess! |
resolves #15 , resolves #16 , resolves #23
Addresses #24
Please review!
Need to check if anchor links work in different_tools page, too.
Thank you :)