Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter sets #99

Merged
merged 6 commits into from
Nov 19, 2020
Merged

Parameter sets #99

merged 6 commits into from
Nov 19, 2020

Conversation

s-fong
Copy link
Contributor

@s-fong s-fong commented Oct 27, 2020

No description provided.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay, fell off my radar as we're pretty busy with deadlines.
Some fixes needed. Note I will re-review and test when these changes are done.

src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_stellate1.py Outdated Show resolved Hide resolved
@s-fong
Copy link
Contributor Author

s-fong commented Nov 19, 2020

Thanks: I have made the fixes as mentioned.

@rchristie rchristie merged commit f3cb148 into ABI-Software:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants