Path1/sidederivatives #93
Conversation
| ("Smooth d1 harmonic", lambda region, options: cls.smoothPath(region, options, DerivativeScalingMode.HARMONIC_MEAN)), | ||
| ("Make D2 normal", lambda region, options: cls.makeD2Normal(region, options)), | ||
| ("Make D3 normal", lambda region, options: cls.makeD3Normal(region, options)) | ||
| ] | ||
|
|
||
|
|
||
| def extractPathParametersFromRegion(region, groupName=None): |
There was a problem hiding this comment.
Pass in list of parameters required as list of node value labels e.g. valueLabels=[Node.VALUE_LABEL_VALUE, Node.VALUE_LABEL_D_DS1]. I think best to be a compulsory second argument.
Update callers to ensure still works. Your functions should only request the parameters they need.
Return sequence of lists.
There was a problem hiding this comment.
I did not understand what you mean here. Do you mean like this?
("Make D2 normal", lambda region, options: cls.makeD2Normal(region, nodeValueLabels, options))
If yes, for D2 I need [Node.VALUE_LABEL_D_DS2] which right now is passed inside the function. Can you please tell me what do you mean?
There was a problem hiding this comment.
I meant only this function signature:
def extractPathParametersFromRegion(region, valueLabels, groupName=None)
No change to makeD2Normal arguments, only changes would be inside it.
There was a problem hiding this comment.
Thanks for elaboration. I will make the change.
|
Thanks for reviewing the code. |
| return cx, cd1, cd2, cd12, cd3, cd13 | ||
| result = () | ||
| for label in valueLabels: | ||
| if label == Node.VALUE_LABEL_VALUE: | ||
| result += (cx,) | ||
| if label == Node.VALUE_LABEL_D_DS1: | ||
| result += (cd1,) | ||
| if label == Node.VALUE_LABEL_D_DS2: | ||
| result += (cd2,) | ||
| if label == Node.VALUE_LABEL_D_DS3: | ||
| result += (cd3,) | ||
| if label == Node.VALUE_LABEL_D2_DS1DS2: | ||
| result += (cd12,) | ||
| if label == Node.VALUE_LABEL_D2_DS1DS3: | ||
| result += (cd13,) |
There was a problem hiding this comment.
This isn't the solution I'm looking for; should instead build the result directly and loop over the number of valueLabels and call getNodeParameters only for those requested in the code earlier.
There was a problem hiding this comment.
I modified the code so it only gets the values specified by valueLabels. What we return depends on the values specified by the valueLabels, I do not know if there is another way to do this. Can you please tell me what else can be done?
There was a problem hiding this comment.
Combine with the evaluation loop:
valueLabelsCount = len(valueLabels)
returnValues = ( [] for i in range(valueLabelsCount) )
while node.isValid():
cache.setNode(node)
for i in range(valueLabelsCount):
result, values = coordinates.getNodeParameters(cache, -1, valueLabels[i], 1, componentsCount)
for c in range(componentsCount, 3):
values.append(0.0)
returnValues[i].append(values)
node = nodeIter.next()
return returnValues
Do check my logic.
There was a problem hiding this comment.
Brilliant! Thanks.
I would like to add some features to 1D path, please.