Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve annotations, refinement and VTK export #70

Merged
merged 15 commits into from
Apr 24, 2020

Conversation

rchristie
Copy link
Member

No description provided.

Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Just a typo to fix and some minor clarifications. I assume that the anatomical IDs are correct for each terms. Also, I did not spend too much time on the parts where you assigned / organised annotations for the heart mesh since I trust you know what you are doing.

src/scaffoldmaker/annotation/annotationgroup.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_heart2.py Outdated Show resolved Hide resolved
Copy link
Member

@mahyar-osn mahyar-osn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I am not sure about the detail of everything; however, I tested the branch with the changes you have done and everything looks and works fine. I only had a small comment/question regarding the heart annotation.

src/scaffoldmaker/annotation/heart_terms.py Show resolved Hide resolved
@rchristie rchristie merged commit 42d56c2 into ABI-Software:master Apr 24, 2020
@rchristie rchristie deleted the fiducial branch April 24, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants