Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for colon and colon segment meshtypes #61

Merged
merged 5 commits into from
Nov 27, 2019

Conversation

mlin865
Copy link
Contributor

@mlin865 mlin865 commented Nov 17, 2019

All tests (inclusive of the one for heart) took 1.3s to run in total. Please review. Thanks.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, should be pretty quick to fix.

src/scaffoldmaker/utils/zinc_utils.py Show resolved Hide resolved
tests/test_colonsegment.py Outdated Show resolved Hide resolved
tests/test_colon.py Outdated Show resolved Hide resolved
@mlin865
Copy link
Contributor Author

mlin865 commented Nov 22, 2019

All requested revisions made. Please review, thanks!

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rchristie rchristie merged commit 3e32f0e into ABI-Software:master Nov 27, 2019
@mlin865 mlin865 deleted the unittest branch November 27, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants