Add sub-scaffolds #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add several default, arbitrary colon central paths.
mlin865
suggested changes
Apr 3, 2019
| coordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D_DS1, 1, dx_ds1) | ||
| nodeIdentifier = nodeIdentifier + 1 | ||
|
|
||
| # create elements |
There was a problem hiding this comment.
Insert ########## above and below #Create elements for consistent style
| from scaffoldmaker.utils.matrix import * | ||
| from scaffoldmaker.utils.meshrefinement import MeshRefinement | ||
| from scaffoldmaker.utils.tubemesh import * | ||
| from scaffoldmaker.utils.zinc_utils import exnodeStringFromNodeValues | ||
|
|
| return optionNames | ||
|
|
||
| def checkOptions(options): | ||
| MeshType_3d_haustra1.checkOptions(options) |
There was a problem hiding this comment.
Why is this deleted? Are options for MeshTyle_3d_haustra1 checked elsewhere?
scaffoldmaker/scaffoldpackage.py
Outdated
| and (self._meshEdits == other._meshEdits) | ||
| return NotImplemented | ||
|
|
||
| def __ne__(self, other): |
There was a problem hiding this comment.
Insert function description
| coordinates.setComponentName(1, 'x') | ||
| coordinates.setComponentName(2, 'y') | ||
| coordinates.setComponentName(3, 'z') | ||
| coordinates = getOrCreateCoordinateField(fm) |
There was a problem hiding this comment.
Make same changes to meshtype_3d_boxhole1.py, meshtyple_3d_sphereshellseptum1.py, meshtype_3d_stomachhuman1.py, meshtype_3d_tube1.py, meshtype_3d_tubeseptum1.py
Plus other minor fixes from code review.
mlin865
approved these changes
Apr 3, 2019
hsorby
reviewed
Apr 3, 2019
Put eft_utils functions in alphabetical order. Move an unrelated function.
mlin865
approved these changes
Apr 8, 2019
Add ScaffoldPackage.getMeshEdits.
mlin865
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add colon central line sub-scaffold.