-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New annotated, poseable body scaffold #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments for you to take a look at.
Issue with converging bifurcation case not working when using 12 elements around, and 8 annotation number of elements around, with solid core on. There seems to be no issue with normal bifurcation case. This has been discussed with Richard. |
Trifurcation also has an issue - 12 elements in, and 8 elements around out without core fails to generate elements properly. |
Fix some tube bifuraction cases. Use core box major/minor internally
Fix core-shell scale factor calculation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of very minor comments.
There is an issue with the 3D body scaffold when the leg lateral angle is greater than 50 degrees, but happy to approve if this is a non-issue.
Better general body shape with poseable human body network layout sub-scaffold.
Add annotations for body internals: abdominal/thoracic cavity boundary, diaphragm, spinal cord.
Add additional skin epidermis subsets for left/right arm/leg.
Improved tube network mesh segment sampling to complete junction transitions in finite distance from junction, handle changes in lateral size and around curves to give expected radial lines of elements.
Use scale factors on final core transition elements to handle different element density/derivative sizes through shell.