Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tube network mesh refactor #259

Merged
merged 22 commits into from
Jul 23, 2024
Merged

Tube network mesh refactor #259

merged 22 commits into from
Jul 23, 2024

Conversation

rchristie
Copy link
Member

No description provided.

oneway1225 and others added 20 commits May 15, 2024 14:44
@oneway1225
Add solid cylinder network scaffold
842ab5b
@rchristie
Add network mesh builder base classes
e748d72
@rchristie
Add box network mesh builder
acf7355
@rchristie
Add tube network mesh builder
c97ccdc
@rchristie
Implement tube network mesh junction
39518b4
@rchristie
Fix cross point derivatives, eft cases
2be1e69
@rchristie
Update uterus2 to use tube network builder
24b247f
@rchristie
Fix uterus broad ligament annotations
b3c2939
@rchristie
Implement tube network trifurcation
c8b0634
@rchristie
Improve segment sampling, trim surfaces
84e8c96
@rchristie
Handle tangential projections in find curve-surface intersections
51a82f5
@rchristie
Improve junction midpoint sampling
05b54b7
@rchristie
Allow more element numbers around combinations
8084a14
@rchristie
Fix tube segment, junction sampling
b17ad10
@rchristie
Make uterus2 human layout symmetric
067c566
@rchristie
Fix uterus symmetry and element spacing
ce4b310
@rchristie
Remove obsolute bifurcation code and scaffolds
d757339
@rchristie
Improve determine serendipity eft by updating deltas
8f93d21
@rchristie
Fix and test tube trifurcations
055ede2
@rchristie
Rescale derivative in determine eft
eaa12c3
oneway1225
oneway1225 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@oneway1225 oneway1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once minor comments are addressed

src/scaffoldmaker/meshtypes/meshtype_3d_uterus2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/cylindermesh.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/cylindermesh.py Outdated Show resolved Hide resolved
tests/test_general.py Outdated Show resolved Hide resolved
@rchristie rchristie merged commit e15eeec into ABI-Software:main Jul 23, 2024
3 checks passed
@rchristie rchristie deleted the solid-cylinder-network-refactor branch July 23, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oneway1225 oneway1225 oneway1225 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchristie @oneway1225