Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box network #246

Merged
merged 8 commits into from
Mar 28, 2024
Merged

Box network #246

merged 8 commits into from
Mar 28, 2024

Conversation

rchristie
Copy link
Member

@rchristie rchristie commented Mar 22, 2024 •
edited
Loading

Requires Zinc 4.1 for new define faces functionality.

mlin865
mlin865 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well for me. Passed all tests. Only 1 minor edit in the docstring and it's all good to go.

src/scaffoldmaker/meshtypes/meshtype_3d_boxnetwork1.py Outdated Show resolved Hide resolved
@rchristie rchristie merged commit cfb68da into ABI-Software:main Mar 28, 2024
@rchristie rchristie deleted the box_network branch March 28, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlin865 mlin865 mlin865 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchristie @mlin865