Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement straight-through bifurcation case #242

Merged
merged 10 commits into from
Jan 31, 2024

Conversation

rchristie
Copy link
Member

Extend tube trim surfaces to further outside tube surface.
Improve convergence of finding nearest points on curves with curvature.

Extend tube trim surfaces to further outside tube surface.
Improve convergence of finding nearest points on curves with curvature.
Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Fix tracksurface curvature calculation
Stop TrackSurface findIntersectionPoint for negligible increment after 50 iterations.
Improve algorithm for getting tube bifurcation cross indexes.
Tidy re-use of cross indexes from outer tube bifurcation data.
Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor line of comment that did not make sense to me. Can you please have a look and revise it.

"""
:param networkSegmentsIn: List of input segments.
:param networkSegmentsOut: List of output segments.
:param segmentTubeData: dict NetworkSegment -> SegmentTubeData.
:param outerTubeData: Optional reference to outer TubeBifurcationData to inherit trim surfaces and
cross indexes from.
cross indexes from. Makes inner bifurcation use same trim surfaces as outer = not currently recommended.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cross indexes from" seems to be hanging and doesn't make much sense to me.

Ensure intersection curve proportions don't wrap between 0.0 and 2.0 for loop TrackSurface.
Fix glitches in stomach with better initial guesses for findNearestPosition (from Mabelle).
Review fixes.
Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well

@rchristie rchristie merged commit a645e2a into ABI-Software:main Jan 31, 2024
@rchristie rchristie deleted the more_bifurcation_cases branch January 31, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants