Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle d1 scaling when using inward and update unit test for bladder #237

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

mlin865
Copy link
Contributor

@mlin865 mlin865 commented Aug 17, 2023

No description provided.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as it's now consistent.
I'm slightly concerned that we're subtracting the curvature to get the factor; makes me wonder why it's getting a negative value for the outward case.
Also noting that relativeThicknessList will need to be used in reverse order for inward extrusion.

@rchristie rchristie merged commit 4f36ff5 into ABI-Software:main Aug 18, 2023
@mlin865 mlin865 deleted the inward branch August 18, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants