Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cecum new #234

Merged
merged 31 commits into from
Mar 14, 2024
Merged

Cecum new #234

merged 31 commits into from
Mar 14, 2024

Conversation

mlin865
Copy link
Contributor

@mlin865 mlin865 commented Jul 21, 2023

Hi Richard,

Note that Ostium 2 only works for 1 vessel at this stage. I kept the code for making multiple vessels (from Ostium 1) in Ostium 2 but they are commented out at this stage. I am hoping to use them later when I start working on implementing multiple vessels for Ostium 2 later on.

Rest of the PR mainly covers the new cecum scaffold and I switched esophagus, small intestine and colon scaffolds to use 1D network layout instead of 1D path. For stomach, I switched over to the 1D network layout to describe the path from fundus to duodenum but I have yet to implement the bifurcation path that joins the esophagus to the stomach. I will work on that after we have a good version of stomach scaffold. Please review.

Thanks,
Mabelle

@mlin865
Copy link
Contributor Author

mlin865 commented Sep 28, 2023

@rchristie - I've made all the changes and added the gastrointestinal tract scaffold as well. This PR is now ready for your review.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've already fixed the number of elements through wall.
A couple of additional fixes, which should be simple.

src/scaffoldmaker/utils/interpolation.py Outdated Show resolved Hide resolved
tests/test_colon.py Outdated Show resolved Hide resolved
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic scaffold!

@rchristie rchristie merged commit 87f380e into ABI-Software:main Mar 14, 2024
@mlin865 mlin865 deleted the cecumNew branch March 28, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants