Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to list where data for scaffold came from #218

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

mlin865
Copy link
Contributor

@mlin865 mlin865 commented Nov 14, 2022

No description provided.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice addition - I can see the work following up all the sources!
Some minor fixes with a couple of references and a small grammar fix.

<https://doi.org/10.1093/nar/gkn613>`_), a pig (Beckman Institute for Advanced Science and Technology, Pig Imaging Group,
University Of Illinois Urbana-Champaign), a rat
(`NeuroRat V4.0 <https://itis.swiss/virtual-population/animal-models/animals/neurorat/neurorat-v4/>`_), and a sheep
(`Nitzsche et al. <https://doi: 10.3389/fnana.2015.00069>`_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this link should be:
https://doi.org/10.3389/fnana.2015.00069


The heart scaffold script generates the scaffold mesh and geometry from ellipsoid and cubic functions with many parameters controlling the shape. The parameters were carefully tuned for each species, and it is not recommended that these be edited.

The rat heart scaffold was calibrated using segmented image data provided from James Schwaber et al. (Thomas Jefferson University). Human and pig hearts were calibrated using data from the literature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clara Leung, Jack Zixi Cheng, Raj Vadigepalli, James Schwaber et al. (TJU, UCF), in SPARC dataset <https://doi.org/10.26275/pb3l-251h>_.

@@ -38,6 +39,10 @@ Note that the D2 and D3 derivatives control the side dimensions, and derivatives
of these along the central path. If editing, use the Interactive Functions to *Smooth derivatives*,
*Make side derivatives normal* and *Smooth side cross derivatives* to make these as smooth as required.

The rat stomach scaffold is parameterized with average data from segmentation of Micro-CT image data of 11 animals
performed at the Powley laboratory using Neurolucida (MBF Bioscience), while the human, mouse, and pig stomach scaffolds
are parameterized with literature data to represent the anatomy as accurate as possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accurately

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@rchristie rchristie merged commit 09d3ccc into ABI-Software:main Nov 17, 2022
@mlin865 mlin865 deleted the updateDoc branch November 17, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants