Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker points #208

Merged
merged 17 commits into from
Aug 24, 2022
Merged

Marker points #208

merged 17 commits into from
Aug 24, 2022

Conversation

mlin865
Copy link
Contributor

@mlin865 mlin865 commented Aug 17, 2022

No description provided.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, mainly just some tidy ups in the utility codes.
Plus some future comments.

src/scaffoldmaker/annotation/annotationgroup.py Outdated Show resolved Hide resolved
src/scaffoldmaker/annotation/annotationgroup.py Outdated Show resolved Hide resolved
src/scaffoldmaker/annotation/annotationgroup.py Outdated Show resolved Hide resolved
src/scaffoldmaker/scaffoldpackage.py Outdated Show resolved Hide resolved
src/scaffoldmaker/scaffoldpackage.py Outdated Show resolved Hide resolved
src/scaffoldmaker/scaffoldpackage.py Show resolved Hide resolved
tests/test_general.py Show resolved Hide resolved
@mlin865
Copy link
Contributor Author

mlin865 commented Aug 24, 2022

All requested changes made and will update test code in future to improve speed. Please review again. Thanks!

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@rchristie rchristie merged commit 4ec168f into ABI-Software:main Aug 24, 2022
@mlin865 mlin865 deleted the markerPoints branch August 24, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants