Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust range of elements according to updated number of elements. #179

Merged
merged 6 commits into from
Oct 31, 2022

Conversation

elias-soltani
Copy link
Contributor

No description provided.

…ate annotation terms for stomach in whole-body according to new terms.
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change these options to "Crop number of elements in direction 1" etc. with values 0, 0 normally -- the first value crops from the low side, the last from the high side. It would be good to make the solid cylinder consistent with this too -- for controlling numbers in the major/minor axes i.e. replace "Lower half".
Storing additional parameters such as "Current number of elements" is a last resort -- I only use this for remembering the parameters set in certain cases.
I notice with the current implementation you can't change the first value from 0 anyway.
Can you please also catch this branch up to main as it's missing the supporting functions for user-defined marker points.
You should update your mesh generator step too: note it has been renamed Scaffold Creator / mapclientplugins.scaffoldcreator as part of the changes for documentation. A new mapclient will migrate workflows to use it.

@elias-soltani
Copy link
Contributor Author

elias-soltani commented Jun 7, 2022

Requested changes implemented.

@rchristie rchristie merged commit 11c447f into ABI-Software:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants