Add solid sphere scaffold #17
Conversation
| 'Number of elements around' : 8, | ||
| 'Number of elements up' : 8, | ||
| 'Number of elements radial' : 1, | ||
| 'Diameter' : 1, |
There was a problem hiding this comment.
Make Diameter a real value: 1.0
| options['Number of elements up'] = 4 | ||
| if options['Number of elements around'] < 4: | ||
| options['Number of elements around'] = 4 | ||
| if options['Diameter'] < 0: |
There was a problem hiding this comment.
Compare/set real values for Diameter: 0.0 and 1.0
scaffoldmaker/scaffoldmaker.py
Outdated
| @@ -20,6 +20,8 @@ | |||
| from scaffoldmaker.meshtypes.meshtype_3d_sphereshellseptum1 import MeshType_3d_sphereshellseptum1 | |||
| from scaffoldmaker.meshtypes.meshtype_3d_tube1 import MeshType_3d_tube1 | |||
| from scaffoldmaker.meshtypes.meshtype_3d_tubeseptum1 import MeshType_3d_tubeseptum1 | |||
| from scaffoldmaker.meshtypes.meshtype_3d_solidsphere1 import MeshType_3d_solidsphere1 | |||
|
|
||
| fm.endChange() | ||
|
|
||
| @staticmethod |
There was a problem hiding this comment.
Change to:
@classmethod
def generateMesh(cls, region, options):
Makes it easy to call cls.generateBaseMesh inside.
| options['Diameter'] = 1 | ||
|
|
||
| @staticmethod | ||
| def generateBaseMesh(region, options): |
There was a problem hiding this comment.
Change signature to:
@classmethod
def generateBaseMesh(cls, region, options):
For consistency with new scaffolds.
scaffoldmaker/utils/eft_utils.py
Outdated
| @@ -98,8 +98,8 @@ def remapEftNodeValueLabel(eft, localNodeIndexes, fromValueLabel, expressionTerm | |||
| :param expressionTerms: List of (valueLabel, scaleFactorIndexesList ) to remap to. | |||
| e.g. [ (Node.VALUE_LABEL_D_DS2, []), (Node.VALUE_LABEL_D_DS3, [5, 6]) ] | |||
| ''' | |||
| functionCount = eft.getNumberOfFunctions() | |||
| for f in range(1, functionCount + 1): | |||
| functionCount = eft.getNumberOfFunctions() | |||
There was a problem hiding this comment.
Remove whitespace changes in this and following line. This file should not be modified.
| Suggestion is to start at 0 and add 100 for each radial line around axis. | ||
| :param nodeScaleFactorOffset0: offset of node scale factors at axis on xi1=0 | ||
| :param nodeScaleFactorOffset1: offset of node scale factors at axis on xi1=1 | ||
| :param nodeScaleFactorOffsetUp: offset of node scale factors as inclination increases |
There was a problem hiding this comment.
offset of first scale factor for inclination at pole, increasing by 2 with each layer away from axis. Suggest starting at 100000 on axis of sphere.
| add 100 for each radial line around axis. | ||
| :param nodeScaleFactorOffset0: offset of node scale factors at axis on xi1=0 | ||
| :param nodeScaleFactorOffset1: offset of node scale factors at axis on xi1=1 | ||
| :param nodeScaleFactorOffsetUp: offset of node scale factors as inclination increases |
There was a problem hiding this comment.
offset of first scale factor for inclination at pole, increasing by 2 with each layer away from axis. Suggest starting at 100000 on axis of sphere.
| add 100 for each radial line around axis. | ||
| :param nodeScaleFactorOffset0: offset of node scale factors at axis on xi1=0 | ||
| :param nodeScaleFactorOffset1: offset of node scale factors at axis on xi1=1 | ||
| :param nodeScaleFactorOffsetUp: offset of node scale factors as inclination increases |
There was a problem hiding this comment.
offset of first scale factor for inclination at pole, increasing by 2 with each layer away from axis. Suggest starting at 100000 on axis of sphere.
| add 100 for each radial line around axis. | ||
| :param nodeScaleFactorOffset0: offset of node scale factors at axis on xi1=0 | ||
| :param nodeScaleFactorOffset1: offset of node scale factors at axis on xi1=1 | ||
| :param nodeScaleFactorOffsetUp: offset of node scale factors as inclination increases |
There was a problem hiding this comment.
offset of first scale factor for inclination at pole, increasing by 2 with each layer away from axis. Suggest starting at 100000 on axis of sphere.
No description provided.