Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shield/sphere #156

Merged
merged 41 commits into from
Nov 10, 2021
Merged

Shield/sphere #156

merged 41 commits into from
Nov 10, 2021

Conversation

elias-soltani
Copy link
Contributor

I would like to add a new scaffold for the solid spheroid, please.

@elias-soltani
Add another script for generating spheroid
ff29f1b
@elias-soltani
Create a 2X2X2 octant. Everything is hard coded and there is an issue…
d26e115 
… to be fixed.
@elias-soltani
Fix refine function
1b06d1c
@elias-soltani
Tidy up the code
4bd166b
@elias-soltani
Fix remapping problem for derivatives for swapping them
69b2292
@elias-soltani
Fix derivatives for the surface node
6b7615a
@elias-soltani
Add rotate vector around vector function
9c09587
@elias-soltani
calculate d2 for ellipse
d9ab223
@elias-soltani
For the shield mesh (2D), allow the derivatives in the regular curves…
babfff1 
… and the circles around to be configurable
@elias-soltani
Make number of elemens across x configurable
9e7e194
@elias-soltani
Make number of elements across y direction configurable.
09e2ad8
@elias-soltani
Make remaps in generating elements easier to modify.
31a3dcb
@elias-soltani
Add octant, hemisphere and full options for the sphere.
95637e9
@elias-soltani
Make number of elements across axis 3 configurable
7f5fbd4
@elias-soltani
Make elements consistent for all of the octants
69223c9
@elias-soltani
Make addVectors work for any number of input vectors.
beff565
@elias-soltani
Make some utility functions for sphere. Make sampling and smoothing f…
194f2be 
…or the sphere surface curves more generic.
@elias-soltani
Fix remapping issue and not used scale factors problem.
c90d795
@elias-soltani
Tidy up the code. Add a function to find index and node parameters of…
95a5475 
… the triple curves
@elias-soltani
Make derivatives in the box configurable.
60295c3
@elias-soltani
Fix hemisphere bugs.
a94916e
@elias-soltani
Fix bugs for full sphere.
7f7b1ab
@elias-soltani
Fix sphere centre bug.
e7fb5ba
@elias-soltani
Add radius options for ellipsoid and spheroid
02d3fdd
@elias-soltani
Fix minor bugs and tidy up.
040af1f
@elias-soltani
Add unittest for sphere mesh.
2391c82
@elias-soltani
Add box and transition groups.
ff5b6b4
@elias-soltani
Merge branch 'main' into shield/sphere
69dffda
@elias-soltani
Fix non-conforming mesh issue and make quadruple curve almost linear.
2f63932
@elias-soltani
Merge branch 'main' into shield/sphere
e81bedf
rchristie
rchristie requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work. A couple of things to fix & I want to have a discussion about handling subsets of the 3D shield.

src/scaffoldmaker/meshtypes/meshtype_3d_solidsphere2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_solidsphere2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_solidsphere2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_solidsphere2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_solidsphere2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_solidsphere2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/shieldmesh.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/shieldmesh.py Show resolved Hide resolved
src/scaffoldmaker/utils/shieldmesh.py Outdated Show resolved Hide resolved
@elias-soltani
Copy link
Contributor Author

Thanks for reviewing the code. I implemented the changes.

rchristie
rchristie approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment/issue has been explained to me and is acceptable.

src/scaffoldmaker/utils/shieldmesh.py Show resolved Hide resolved
@rchristie rchristie merged commit a23f243 into ABI-Software:main Nov 10, 2021
@elias-soltani elias-soltani deleted the shield/sphere branch November 10, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchristie rchristie rchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elias-soltani @rchristie