Created parameters for rat and human #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated cylinderCentralPath for the annotated groups Added brain terms marker points
rchristie
requested changes
Jun 3, 2021
There was a problem hiding this comment.
It's progressing, but not quite what I expected, which is for all species to have a brainstem with 10 elements along in ratio 2-4-4 midbrain-pons-medulla (so actually easier than what you've done). I don't trust the cat shape and would extend the midbrain further to keep the 2-4-4 ratio for it.
It's not bad that you've annotated the central path - leave it in, but it isn't until the cylinder mesh can be built with variable spacing that we can make the final mesh reflect what you have in there.
There are more things I could give feedback on in the code, but let's get it working as expected first, shouldn't take too long.
rchristie
requested changes
Jun 7, 2021
rchristie
reviewed
Jun 7, 2021
rchristie
reviewed
Jun 7, 2021
rchristie
requested changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated cylinderCentralPath for the annotated groups
Added brain terms marker points