created lung fissure annotation #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test_lung.py requires humanFiducialPoint branch to run a test for marker points
rchristie
requested changes
May 10, 2021
rchristie
requested changes
May 11, 2021
rchristie
reviewed
May 11, 2021
| upperLeftGroup = getAnnotationGroupForTerm(annotationGroups, get_lung_term("upper lobe of left lung")) | ||
| lowerLeftGroup = getAnnotationGroupForTerm(annotationGroups, get_lung_term("lower lobe of left lung")) | ||
|
|
||
| mesh2d = fm.findMeshByDimension(2) |
There was a problem hiding this comment.
Move this line above if isHuman:
Fails for mouse as mesh2d isn't defined for the right side. Please test mouse runs, check your lung test passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no such terms called oblique and horizontal fissures on SciCrunch. I will request those terms on SciCrunch as we discussed yesterday