Right and accessory lungs #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the node and elements function for the accessory lung including its parameters were added into the mouse section
rchristie
requested changes
Feb 9, 2021
There was a problem hiding this comment.
Refactoring into functions is really improving this code... well done.
Some fixes needed, especially the inconsistency between 2 pairs of elements in the diaphragmatic lobe which I sent a graphic of on Slack; I think I've marked the offending lines in the code review.
…90-91), changed the mouse parameters to 3.5f
rchristie
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the node and element functions (i.e. getLungNodes, getLungElements, getDiaphragmaticLungNodes, getDiaphragmaticLungElements) for both right, left and accessory lungs including its parameters were added into the human and mouse sections (excluding the left mouse lung)