Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth derivative directions, add function options #110

Merged
merged 5 commits into from
Dec 9, 2020

Conversation

rchristie
Copy link
Member

No description provided.

@rchristie
Copy link
Member Author

Users will need update in ABI-Software/mapclientplugins.scaffoldcreator#28.

Copy link
Member

@mahyar-osn mahyar-osn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes. Otherwise, all good. Reviewed and tested.

src/scaffoldmaker/utils/derivativemoothing.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/derivativemoothing.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/derivativemoothing.py Outdated Show resolved Hide resolved
Copy link
Member

@mahyar-osn mahyar-osn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

@rchristie rchristie merged commit a7310c9 into ABI-Software:master Dec 9, 2020
@rchristie rchristie deleted the smooth_direction branch December 9, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants