Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit 'data_coordinates' field for fiducial points #53

Closed
mahyar-osn opened this issue Jun 16, 2019 · 1 comment · Fixed by #57
Closed

Edit 'data_coordinates' field for fiducial points #53

mahyar-osn opened this issue Jun 16, 2019 · 1 comment · Fixed by #57

Comments

@mahyar-osn
Copy link
Member

It would be very helpful to distinguish data points from segmented fiducial points by having a different field name from the current 'data_coordinates' to something else, for example 'fiducial_coordinates'.
@rchristie
Copy link
Member

I'll change fields prefixed by 'data' to be prefixed by 'fiducial' e.g.:
fiducial_coordinates
fiducial_label
fiducial_element_xi

Note this change will require meshgeneratorstep to be updated.

rchristie added a commit to rchristie/scaffoldmaker that referenced this issue Jul 10, 2019
@rchristie
Rename data fields to fiducial
7584c20 
Fixes ABI-Software#53.
Note also requires an update to mapclient plugin meshgeneratorstep.
@rchristie rchristie mentioned this issue Jul 10, 2019
Merged
hsorby added a commit that referenced this issue Jul 10, 2019
@hsorby
Merge pull request #57 from rchristie/fiducial
448da81 
Rename data fields to fiducial.  Closes #53.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename data fields to fiducial rchristie/scaffoldmaker
2 participants
@rchristie @mahyar-osn