-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve multiflatmap start up. #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is switching to only using multiflatmapvuer for the mapimp.
I'm guessing we don't use the singular flatmapvuer in mapintegratedvuer anymore?
if (this.entry.type === "Flatmap") { | ||
return this.$refs.flatmap.mapImp; | ||
} else if (this.entry.type === "MultiFlatmap") { | ||
if (this.entry.type === "MultiFlatmap") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the normal flatmap not have a viewer anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is and is handled in Flatmap.vue. This should have been removed when I did the refactoring.
@@ -36,7 +36,7 @@ | |||
"@abi-software/flatmapvuer": "^0.5.4", | |||
"@abi-software/map-side-bar": "^1.4.1-beta.1", | |||
"@abi-software/plotvuer": "^0.3.9", | |||
"@abi-software/scaffoldvuer": "^0.2.1", | |||
"@abi-software/scaffoldvuer": "^0.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was the scaffoldvuer change related to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes related to a Portal ticket in it.
I ran this locally, it worked as I would expect where I tested it. I couldn't notice any speed increases though Took me about 12s without cash, 10s with cache locally with about 3s variance I get pretty similar times on sparc.science |
This patch is not about the speed, it is about starting the map and getting the information in them in a more reliable way, i.e making sure the markers are set in the correct species. |
No description provided.