Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multiflatmap start up. #168

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Improve multiflatmap start up. #168

merged 4 commits into from
Jul 20, 2023

Conversation

alan-wu
Copy link
Member

@alan-wu alan-wu commented Jul 17, 2023

No description provided.

@alan-wu alan-wu requested a review from Tehsurfer July 19, 2023 00:44
Copy link
Contributor

@Tehsurfer Tehsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is switching to only using multiflatmapvuer for the mapimp.

I'm guessing we don't use the singular flatmapvuer in mapintegratedvuer anymore?

if (this.entry.type === "Flatmap") {
return this.$refs.flatmap.mapImp;
} else if (this.entry.type === "MultiFlatmap") {
if (this.entry.type === "MultiFlatmap") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the normal flatmap not have a viewer anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is and is handled in Flatmap.vue. This should have been removed when I did the refactoring.

@@ -36,7 +36,7 @@
"@abi-software/flatmapvuer": "^0.5.4",
"@abi-software/map-side-bar": "^1.4.1-beta.1",
"@abi-software/plotvuer": "^0.3.9",
"@abi-software/scaffoldvuer": "^0.2.1",
"@abi-software/scaffoldvuer": "^0.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the scaffoldvuer change related to this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes related to a Portal ticket in it.

@Tehsurfer
Copy link
Contributor

I ran this locally, it worked as I would expect where I tested it.

I couldn't notice any speed increases though

Took me about 12s without cash, 10s with cache locally with about 3s variance

I get pretty similar times on sparc.science

@alan-wu
Copy link
Member Author

alan-wu commented Jul 20, 2023

I ran this locally, it worked as I would expect where I tested it.

I couldn't notice any speed increases though

Took me about 12s without cash, 10s with cache locally with about 3s variance

I get pretty similar times on sparc.science

This patch is not about the speed, it is about starting the map and getting the information in them in a more reliable way, i.e making sure the markers are set in the correct species.

@alan-wu alan-wu merged commit 6beffbf into ABI-Software:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants