Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set current entry #147

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Set current entry #147

merged 8 commits into from
Feb 17, 2023

Conversation

alan-wu
Copy link
Member

@alan-wu alan-wu commented Feb 2, 2023

Add a new method to programmatically set the current view. Refactor some aspects of the viewer to separate out the initial state and available species information from the vue codes. This implementation is required to support the feature request in this ticket.

@alan-wu alan-wu requested a review from Tehsurfer February 2, 2023 21:36
Copy link
Contributor

@Tehsurfer Tehsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes! I put a few small comments

@@ -116,7 +148,10 @@ export default {
}
},
mounted: function() {
this._mapSettings = [];
//this.setMultiFlatmap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need these lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional but I keep it there for testing before the map is properly loaded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good idea

src/components/viewers/MultiFlatmap.vue Outdated Show resolved Hide resolved
src/components/MapContent.vue Show resolved Hide resolved
src/components/scripts/utilities.js Outdated Show resolved Hide resolved
@alan-wu alan-wu merged commit 5ca5bd5 into ABI-Software:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants