Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update map-side-bar for better context card banners #127

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Update map-side-bar for better context card banners #127

merged 3 commits into from
Oct 13, 2022

Conversation

Tehsurfer
Copy link
Contributor

@Tehsurfer Tehsurfer commented Sep 30, 2022 •
edited
Loading

Update map-sidebar and update mapintegratedvuer version.

image

context cards now take context banners in the following order:

  1. Look for a banner field on the top level of scaffold_context_info.json. The sidebar expects this to be a file path to the banner
  2. Use the first view's thumbnail image
  3. Use the dataset's banner image

This can be checked with dataset 259

information panel text has been updated

@Tehsurfer Tehsurfer requested a review from alan-wu October 11, 2022 01:22
alan-wu
alan-wu approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@Tehsurfer Tehsurfer merged commit ff1728f into ABI-Software:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-wu alan-wu alan-wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tehsurfer @alan-wu