Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sidebar to set the views of a scaffold #105

Merged
merged 15 commits into from
Apr 28, 2022

Conversation

Tehsurfer
Copy link
Contributor

@Tehsurfer Tehsurfer commented Apr 7, 2022

This can be tested on the colon scaffold:
image

@Tehsurfer Tehsurfer marked this pull request as draft April 7, 2022 23:04
@Tehsurfer Tehsurfer marked this pull request as ready for review April 27, 2022 00:12
@alan-wu
Copy link
Member

alan-wu commented Apr 27, 2022

@Tehsurfer I have added semi-colons to keep things consistent and also create a patch up version of the sidebar to fix simulationvuer event and hide the "Samples on scaffold" text when sample size is 0.

Future improvements include:
Look into the sizing issue on the contextual information, it expands the width when it is opened.
The information should not be shown on unrelated context.

Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment for future improvements.

@Tehsurfer
Copy link
Contributor Author

Tehsurfer commented Apr 27, 2022

@alan-wu thank you!

semi-colons to keep things consistent

Sorry about that! missed this

"Samples on scaffold" text when sample size is 0.

Oh yeah sorry I did patch this but maybe it had not updated the sidebar version here

@Tehsurfer
Copy link
Contributor Author

Tehsurfer commented Apr 27, 2022

Look into the sizing issue on the contextual information, it expands the width when it is opened.

I didn't notice this, will fix

The information should not be shown on unrelated context.

Will fix this asap

@Tehsurfer Tehsurfer requested a review from alan-wu April 27, 2022 22:59
@alan-wu alan-wu merged commit 544b8fb into ABI-Software:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants