Dynamic flatmap markers #102
Conversation
- keywords now search via the search rather than filter - remove some unused resource-selected types - add keyword key to markerZoom
src/components/SplitFlow.vue
Outdated
| } else if (action.type == "Facet") { | ||
| const speciesFacets = []; | ||
| } else if (action.type == "Facet") { | ||
| console.log('action', action) |
src/components/SplitFlow.vue
Outdated
| store.state.settings.facets.species.forEach(e => { | ||
| speciesFacets.push({facet: e, term:'species'}); | ||
| facets.push({facet: e, term:'Species', facetPropPath: 'anatomy.organ.name'}); |
There was a problem hiding this comment.
Is the facetPropPath correct for species?
There was a problem hiding this comment.
yeah you are right
src/components/SplitFlow.vue
Outdated
| speciesFacets.push({facet: "show all", term:'species'}); | ||
| this.$refs.sideBar.addFilter({facet: action.label, term:'Anatomical structure', facetPropPath: 'anatomy.organ.name'}); | ||
| if (facets.length == 0) | ||
| facets.push({facet: "Show All", term:'Species', facetPropPath: 'anatomy.organ.name'}); |
| const speciesFacets = []; | ||
| } else if (action.type == "Facet") { | ||
| console.log('action', action) | ||
| this.$refs.sideBar.addFilter(action); |
There was a problem hiding this comment.
Instead of having two separate blocks, Can this be replaced by the Facets block instead?
There was a problem hiding this comment.
the Facet action adds on facet to the current facets, as the Facets action clears all facets and sets new ones. I think we need boths
src/components/SplitFlow.vue
Outdated
| @@ -137,6 +139,10 @@ export default { | |||
| if (data && (data.type == "filter-update")) { | |||
| store.commit("settings/updateFacets", data.value); | |||
| } | |||
| if (data && data.type == "keyword-update") { | |||
| console.log('starting keyword update with: ', data.value) | |||
| @@ -74,6 +76,7 @@ export default { | |||
| payload: payload, | |||
| type: this.entry.type, | |||
| }; | |||
| this.handleSyncPanZoomEvent(result) | |||
There was a problem hiding this comment.
This should call this.flatmapMarkerZoomUpdate directly. The handleSyncPanZoomEvent will prevent any update on the marker if the mouse cursor is on the flatmap.
src/mixins/ContentMixin.js
Outdated
| returnedAction.type = "Facet"; | ||
| returnedAction.label = this.idNamePair[resource.feature.models]; | ||
| let label = this.idNamePair[resource.feature.models] | ||
| window.label = label |
There was a problem hiding this comment.
Remove all the temporary objects from window please.
| } else { | ||
| // Facet search on anatomy if it is not a keyword search | ||
| returnedAction = { | ||
| type: "Facet", |
There was a problem hiding this comment.
Can we change this so that we can use the Facets block as well?
There was a problem hiding this comment.
we want markers to add a filter to the current filter in the sidebar
There was a problem hiding this comment.
(which is what the 'Facet' action does. 'Facets' clears and sets a what array of facets is given)
| // Facet search on anatomy if it is not a keyword search | ||
| returnedAction = { | ||
| type: "Facet", | ||
| facet: label, |
There was a problem hiding this comment.
label is undefined here, I used to call this.idNamePair[resource.feature.models] to get the label instead.
| } | ||
| }, | ||
| flatmapMarkerZoomUpdate(){ | ||
| let flatmapImp = this.getFlatmapImp() |
There was a problem hiding this comment.
Calling the clearMarkers and addMarker at every zoom event can be intensive. Can we store the current zoom level and only update the markers when the zoom level has changed?
- Add semicolons - Remove remaining debug vars - Switch marker update so it only happens on zoom level change - Add an event for searches to update markers
| this.zoomLevel = currentZoom; | ||
| this.flatmapMarkerZoomUpdate(); | ||
| } | ||
| this.handleSyncPanZoomEvent(result); |
There was a problem hiding this comment.
Do not call handleSyncPanZoomEvent here please, that method should be called only when it is triggered by external callback.
| @@ -107,7 +119,6 @@ export default { | |||
| .getCurrentFlatmap() | |||
| .mapImp.panZoomTo(origin, [sW, sH]); | |||
| } | |||
| this.flatmapMarkerZoomUpdate() | |||
There was a problem hiding this comment.
Keep this method, this method gets called by synchronised zoom event. The markers should be updated.
Fix several minor issues.
Fix Search for dataset on upstream downstream not working.
This can be viewed at https://algolia-maps.herokuapp.com/maps
