Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More annotation tool update #216

Merged
merged 11 commits into from
Jan 6, 2025

Conversation

ddjnw1yu
Copy link
Contributor

@ddjnw1yu ddjnw1yu commented Dec 2, 2024

Require the following PR:

Changes:

  • bug fixed (click on the nodes of drawn features)
  • filter removed (drawn by)
  • content modifed
Screenshot 2024-12-02 at 1 13 46 PM Screenshot 2024-12-02 at 2 18 06 PM Screenshot 2024-12-02 at 2 19 29 PM

@ddjnw1yu ddjnw1yu marked this pull request as draft December 2, 2024 20:52
@ddjnw1yu ddjnw1yu marked this pull request as ready for review December 3, 2024 02:01
Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

for (const feature of drawnFeatures) {
this.mapImp.addAnnotationFeature(feature)
}
if (!this.featureAnnotationSubmitted) this.loading = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be put into the same conditional block as the line above.

@alan-wu alan-wu merged commit e08a98e into ABI-Software:main Jan 6, 2025
1 check passed
@ddjnw1yu ddjnw1yu deleted the more-annotation-tool-update branch January 7, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants