Patchcheck tmp2 #14
Closed
Patchcheck tmp2 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Sep 17, 2023
| @@ -175,6 +187,15 @@ def report_modified_files(file_paths): | |||
| 'Tools/c-analyzer/cpython/_parser.py', | |||
| }) | |||
|
|
|||
| #: Python files with bad syntax | |||
There was a problem hiding this comment.
Suggested change
| #: Python files with bad syntax | |
| # Python files with bad syntax |
There was a problem hiding this comment.
Copied the style from the above (this is the style Sphinx uses for documentation comments, but unsure why the above used it)
Comment on lines
+192
to
+195
| 'Lib/test/tokenizedata/bad_coding.py', | ||
| 'Lib/test/tokenizedata/bad_coding2.py', | ||
| 'Lib/test/tokenizedata/badsyntax_3131.py', | ||
| 'Lib/test/tokenizedata/coding20731.py', |
There was a problem hiding this comment.
To avoid hardcoding filenames, we could skip the whole tokenizedata directory, as we did in python#109513.
Comment on lines
+34
to
+35
| with: | ||
| show-progress: false |
There was a problem hiding this comment.
Suggested change
| with: | |
| show-progress: false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--14.org.readthedocs.build/