Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] QA 반영 #24

Merged
merged 10 commits into from
Sep 25, 2024
Merged

[Fix] QA 반영 #24

merged 10 commits into from
Sep 25, 2024

Conversation

gmlwlsdl
Copy link
Collaborator

@gmlwlsdl gmlwlsdl commented Sep 24, 2024 •
edited
Loading

#️⃣연관된 이슈

📝작업 내용

  1. 새 질문 받아오기 버튼 (GetQuestionBtn)의 활성화 관련 에러 수정하였습니다.
    1-1. 답변 상자의 가로 스크롤을 제거, 세로 스크롤 숨김처리 해두었습니다.
  2. 답변 모달 뒷벼경 투명도를 조정하였습니다.
  3. 가족 리스트 박스의 height를 조정하여 외부 박스와의 간격을 넓혔습니다.
    공인 ip에서 접속할 수 있도록 수정하였습니다.

스크린샷 (선택)

1 2 3
image image image

💬리뷰 요구사항

@gmlwlsdl gmlwlsdl requested a review from boroboro01 September 24, 2024 13:26
@gmlwlsdl gmlwlsdl self-assigned this Sep 24, 2024
@gmlwlsdl
chore: Update vite.config.ts
77f5d49 
- index.html meta 태그 제거
- vite.config.ts hmr 제거
boroboro01
boroboro01 requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@boroboro01 boroboro01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA 진행하느라 고생하셨습니다! 충돌 해결 후 바로 머지하겠습니다!

@boroboro01 boroboro01 merged commit 7de005a into main Sep 25, 2024
@boroboro01 boroboro01 deleted the fix/qa branch September 25, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boroboro01 boroboro01 boroboro01 approved these changes

Assignees

@gmlwlsdl gmlwlsdl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmlwlsdl @boroboro01