Fixes #843: Bind to embedded struct method or field #919
+492
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to write test cases for the buggy
codegen.builder#findBindTarget
method as initially raised in #843 .Some of the issues:
I'm not entirely sure what's the expected behaviour in some of this cases since this docs, code comments here and examples (I'm certain I've seen an example on how to bind to an embedded interface) seem to contradict at times each other.
A way to fix some of these issues would be to use
types.LookupFieldOrMethod
. If there's some alignment on what the spec should be, I'm happy to update this PR with code that solves the issues.The best way to run these tests is:
I have: