-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding requestHeaders to the websocket client #832
Conversation
hmm the lint fails with
but that body is being closed inside the |
try a rebase, I fixed a few of these ~0.9.2 ish. |
PR message could use more explaining why this would be useful, and probably tests/docs on showing how it would be used. |
fixing tests renaming better
I did and the same results 😢
Added. Let me know if more doc or tests are needed , although the type added is pretty clear |
Hmm yeah, it's not failing on master but something about your change is confusing the linter. Lets just skip it, this is just the test client.
|
Please a look at #861 and see if it covers your use case |
yeah I think with https://github.com/99designs/gqlgen/pull/861/files#diff-3c0b8ea9d09776a0db9bab04cf0a6ea7R32 it can be added the headers to the websocket requests. I'll close the issue in lieu of that PR. |
Adding
requestHeaders
argument to the websocket client funcs to have the possibilty of passing request Headers .For example, if you need to pass other authorization header like
X-Auth-Token
or/and other headers likeSec-WebSocket-Key
,Sec-WebSocket-Version
this PR opens that possibility.Example: