Automatic Persisted Queries #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radev
reviewed
Jun 12, 2019
There was a problem hiding this comment.
This implementation will work only with single graphql server instance or sticky sessions.
With load-balancing follow-up query can land on a different server, so it will take some until all servers will receive APQ hash.
I would suggest doing interface to support pluggable implementation (e.g. shared redis cache).
I would suggest doing interface to support pluggable implementation
|
See DBL-Lee#1 for proposed implementation |
Support for external APQ cache
|
this looks solid 👍 |
|
Thanks for the PR. I gave it a test run on one of our projects, docs are good, everything seems to work. The handler package is becoming a bit big, we will have to do something to make it a bit more modular in the future. |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Automatic Persisted Queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements automatic persisted queries as described here
It follows apollo server implementation here to make sure it is compatible with apollo clients.
This have been running in our production environment for a few weeks and works well with Apollo client with APQ enabled.
This implements #401
I have: