Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Split client.Post into client.NewRequest & client.Do #720

Closed
wants to merge 1 commit into from
Closed

[RFC] Split client.Post into client.NewRequest & client.Do #720

wants to merge 1 commit into from

Conversation

lwc
Copy link
Member

@lwc lwc commented May 22, 2019

We'd like to be able to set cookies on the test client. Splitting NewRequest from Do seemed to be the easiest way to add a bunch of capability. The existing Post and PostRaw are still intact, but now call NewRequest & Do under the hood.

I have:

@lwc lwc force-pushed the gqlclient-split-do branch from 69046d9 to e14abfe Compare May 22, 2019 01:13
@lwc lwc force-pushed the gqlclient-split-do branch from e14abfe to 6819b28 Compare May 22, 2019 01:23
@lwc lwc changed the title Split client.Post into client.NewRequest & client.Do [RFC] Split client.Post into client.NewRequest & client.Do May 22, 2019
@lwc lwc closed this May 31, 2019
@vektah vektah mentioned this pull request Sep 16, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lwc