Improved Collect Fields API and Documentation #551
Merged
+149
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vektah
reviewed
Feb 18, 2019
| @@ -38,7 +41,7 @@ func collectFields(reqCtx *RequestContext, selSet ast.SelectionSet, satisfies [] | |||
| if !shouldIncludeNode(sel.Directives, reqCtx.Variables) { | |||
| continue | |||
| } | |||
| if !instanceOf(sel.TypeCondition, satisfies) { | |||
| if len(satisfies) > 0 && !instanceOf(sel.TypeCondition, satisfies) { | |||
There was a problem hiding this comment.
should this be an explicit nil check? is there a difference between satisfies = nil and satisfies = []? maybe [] is not useful so the distinction is not important?
There was a problem hiding this comment.
Yeah perhaps. Currently on next an empty slice will collect object fields, and skip any Fragments. Is that useful? Maybe, I guess it does potentially break BC if anyone is using it for this use-case.
Still, a nil slice vs and empty slice having different behaviours seems a little fragile to me?
vektah
approved these changes
Feb 18, 2019
Merged
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
…ds-api Improved Collect Fields API and Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new API helper method
CollectAllFields(context.Context) []stringas discussed in #280 and #533. The goal is to add a simple API for the common case of wanting to know which fields were requested, and add some documentation around how this feature works.