Union Fragment Bug Fix #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewbyrne
force-pushed
the
union-fragment-bug
branch
from
6252c0a to
f13b5ae
Compare
added 3 commits
February 8, 2019 10:31
These conditions are not really related, and I missed the second conditional when reading through the first time.
mathewbyrne
force-pushed
the
union-fragment-bug
branch
from
f13b5ae to
99e9f41
Compare
Merged
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Union Fragment Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #399
The issue that is being run into is that union types delegate their field collection to the concrete type that is resolved. The problem occurs when the selection is on a Union type, which is not listed in the concrete implementors, and thus is skipped during field collection.
The solution is to include Unions in the list of implementors for each concrete type. This can be retrieved with
ast.Schema.GetImplements.@vektah has already fixed this issue in https://github.com/99designs/gqlgen/tree/multiple-bind-types which will merge prior to next release.Not quite, a small fix is still required in this PR.