Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #497

Merged
merged 4 commits into from
Jan 14, 2019
Merged

Small fixes #497

merged 4 commits into from
Jan 14, 2019

Conversation

azavorotnii
Copy link
Contributor

No particular issue, just small things that I found in code.

@azavorotnii
Copy link
Contributor Author

Strange failure:

    --- FAIL: TestGeneratedServer/subscriptions (2.01s)
        --- FAIL: TestGeneratedServer/subscriptions/wont_leak_goroutines (2.01s)
	Error Trace:	generated_test.go:151
	Error:      	Not equal: 
	            	expected: 9
	            	actual  : 8
	Test:       	TestGeneratedServer/subscriptions/wont_leak_goroutines

So at the end one less goroutine active than was at the beginning of test. Should there be settlement loop at the beginning of test as well? It just looks one extra goroutine was active at the beginning of test.

@vektah vektah changed the base branch from master to next January 14, 2019 22:25
@vektah
Copy link
Collaborator

vektah commented Jan 14, 2019

Thanks for the PR.

Please make sure any future work is based on the next branch, there are some large refactors that would make rebasing between the two pretty hard.

@vektah vektah merged commit f94b4b7 into 99designs:next Jan 14, 2019
@azavorotnii
Copy link
Contributor Author

Got it. Is there a schedule how often "next" merged into "master"?

@vektah
Copy link
Collaborator

vektah commented Jan 15, 2019

You can track the 0.8 progress on the board. The refactor card is much much larger than the features we are adding, so probably the next week or two.

Non breaking bug fixes could probably go straight to master for a quick 0.7.2, but right now, with such a large refactor it would basically need to be written twice.

cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants