Tracer: fixed nil pointer issue #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now code generated with latest master fails since there are usages of Trace but there is no any single write to this variable
|
Yes, that fixed the issue with the generated code not having the Tracer: graph/generated.go:204:10: ec.Tracer undefined (type *executionContext has no field or method Tracer) |
|
@nmijailovic you could temporary use my repo |
|
@yurykozyrev thx, have already updated code locally from your diff, it is now working. |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Tracer: fixed nil pointer issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now code generated with latest master fails since there are usages of
RequestContext.Tracerbut there is no initialization of it or any write to this variable