copy complexity to RequestContext #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to see the complexity of each path, but it looks difficult 🤔 |
vektah
reviewed
Oct 30, 2018
| @@ -17,6 +17,10 @@ type RequestContext struct { | |||
| RawQuery string | |||
| Variables map[string]interface{} | |||
| Doc *ast.QueryDocument | |||
|
|
|||
| ComplexityLimit int | |||
There was a problem hiding this comment.
why is ComplexityLimit here, its static?
There was a problem hiding this comment.
Yes it's static value determined at compile time.
BTW, I want to modify it on run time...
There was a problem hiding this comment.
BTW, I want to modify it on run time...
🤔
when? ideally a request over the limit doesn't run anything, especially not in the resolver stack.
There was a problem hiding this comment.
For example, If we want to change ComplexityLimit between 1st party client and 3rd party client.
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
copy complexity to RequestContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to get access to operation complexity on Tracing.
I have: