Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse errors and data order in response #369

Merged
merged 2 commits into from
Oct 15, 2018
Merged

reverse errors and data order in response #369

merged 2 commits into from
Oct 15, 2018

Conversation

vetcher
Copy link
Contributor

@vetcher vetcher commented Oct 4, 2018

Following the trend and recommendations in graphql: graphql/graphql-spec#384

Note: When errors is present in the response, it may be helpful for it to
appear first when serialized to make it more clear when errors are present
in a response during debugging.

@vektah
Copy link
Collaborator

vektah commented Oct 10, 2018

Happy to merge this, but the tests need to be updated.

@vektah vektah merged commit 20a5b6c into 99designs:master Oct 15, 2018
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#369 from vetcher/master
43af2cd 
reverse errors and data order in response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vetcher @vektah