Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unneeded check #3394

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

alexandear
Copy link
Contributor

omittableType == nil is always true, because omittableType is declared as var omittableType types.Type and is nil (types.Type is an interface). This was found by the govet.nilness check:

❯ golangci-lint run
plugin/modelgen/models.go:454:20: nilness: tautological condition: nil == nil (govet)
                if omittableType == nil {
                                 ^

I have:

  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

coverage: 59.74% (-0.01%) from 59.753%
when pulling a57e6f1 on alexandear:refactor/fix-nilness
into 0d5b25e on 99designs:master.

@StevenACoffman StevenACoffman merged commit b110c1d into 99designs:master Nov 25, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants