Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds docs for how resolvers are bound #338

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Adds docs for how resolvers are bound #338

merged 2 commits into from
Sep 12, 2018

Conversation

codyleyhan
Copy link
Contributor

Adds documentation about all the different ways that resolvers can be bound

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

vektah
vektah reviewed Sep 12, 2018
View reviewed changes
docs/content/reference/resolvers.md Outdated

```go
type Truck {
car
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Car?

vektah
vektah reviewed Sep 12, 2018
View reviewed changes
docs/content/reference/resolvers.md Outdated
type Truck {
car

is4x4 bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Is4x4?

@vektah
Copy link
Collaborator

vektah commented Sep 12, 2018

Thanks for the PR, looks good!

@vektah vektah merged commit 535dd24 into 99designs:master Sep 12, 2018
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#338 from codyleyhan/cl/docs
3a9eef7 
Adds docs for how resolvers are bound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vektah vektah vektah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codyleyhan @vektah