Add support for embedded structs #3242
Open
+293
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlungu
changed the title
adrianlungu
force-pushed
the
embed-struct
branch
from
07af270
to
849731b
Compare
|
Made an update to:
|
|
Security check seems to be failing on something from upstream ? 🤔 |
|
Any news on this ? is there anything else that should be done to get this up and running ? 🙏 |
fix missing return in model plugin getObject; refactor to use `getObject` to create the base struct to be used in embedding; add test for embedded structs; update models.gotpl to not create the `` for tags when there are no tags add support for embedded structs when a graphql type implements an interface
adrianlungu
force-pushed
the
embed-struct
branch
from
b07f5e8
to
1bc7e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is an attempt at implementing support for embedded types, as also described here.
The current implementation generates a base struct from any
interface, which is subsequently embedded in any struct that implements that given interface.It is quite naive at the moment, i.e. if you have a GraphQL type implementing multiple interfaces sharing the same fields, it will create an ambiguity issue in the getters.
Configuration options have been added to enable this functionality, and it's disabled by default. The
Baseprefix can also be changed in case someone wants the base structs to not be exported, or prefers a different naming convention.This is tricky to get right but any feedback and/or support on making this better is welcome!
I have: