Bugfix: add missing return statements in GRAPHQL and UrlEncodedForm t… #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransports. Two transports (GRAPHQL and UrlEncodedForm) did not have return statement at the end of `if err` block. Instead of returning a 'could not cleanup body' error, we continued processing. User still got an error. But instead of early 'could not cleanup' error, user gor 'Internal system error' which happened a few lines after the if block. Tests are added.
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ransports.
Two transports (GRAPHQL and UrlEncodedForm) did not have return statement at the end of
if errblock. Instead of returning a 'could not cleanup body' error, we continued processing.User still got an error. But instead of early
could not cleanuperror, user gotInternal system errorwhich happened a few lines after the if block.While at it, remove the not needed
log.Printf()lines.Tests are added.
Describe your PR and link to any relevant issues.
I have: