Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Interface Slice Getter Generation #2332

Merged
merged 3 commits into from
Aug 20, 2022
Merged

Fix Interface Slice Getter Generation #2332

merged 3 commits into from
Aug 20, 2022

Conversation

neptoess
Copy link
Contributor

Resolves #2331

Bill Rose added 2 commits August 19, 2022 10:32
@coveralls
Copy link

coveralls commented Aug 19, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-1.6%) to 75.454% when pulling 8278a3e on neptoess:bugfix/interface-slices into aee57b4 on 99designs:master.

argoyle
argoyle reviewed Aug 19, 2022
View reviewed changes
Copy link

@argoyle argoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a suitable solution. 🚀

@neptoess
Copy link
Contributor Author

neptoess commented Aug 19, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-1.6%) to 75.454% when pulling 8278a3e on neptoess:bugfix/interface-slices into aee57b4 on 99designs:master.

Bad bot :)
@StevenACoffman is this something that will block the merge? I actually did add test cases for the code I added. I think it might be considering the generated file for coverage calculation

@MichaelMure MichaelMure mentioned this pull request Aug 20, 2022
Closed
@StevenACoffman StevenACoffman merged commit 2b58401 into 99designs:master Aug 20, 2022
@StevenACoffman
Copy link
Collaborator

Yeah, you're right, the config doesn't currently exclude the generated code so it's a noisy signal. Thanks so much for looking into this and continuing to improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argoyle argoyle argoyle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.17.14 generate getters for interfaces problem
4 participants
@neptoess @coveralls @StevenACoffman @argoyle