fixed introspection for schema description and specifiedByURL #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code-Hex
commented
Feb 23, 2022
|
I've checked with rewrote go.mod like below |
This was referenced Feb 28, 2022
Code-Hex
force-pushed
the
fix/prelude-october-2021
branch
from
47bb408 to
33a6c59
Compare
Code-Hex
force-pushed
the
fix/prelude-october-2021
branch
from
33a6c59 to
2fee560
Compare
Code-Hex
changed the title
Code-Hex
commented
Feb 28, 2022
| @@ -31,7 +31,7 @@ in another terminal | |||
| ```bash | |||
| cd integration | |||
| npm install | |||
| SERVER_URL=http://localhost:8080/query ./node_modules/.bin/graphql get-schema | |||
| ./node_modules/.bin/graphql-codegen | |||
There was a problem hiding this comment.
use graphql-codegen because need to upgrade graphql-js to v16.3.0 (the same as gqlparser) and graphql-cli is wrapper for it
|
@StevenACoffman Could you check? |
Code-Hex
commented
Feb 28, 2022
go.mod
Outdated
| @@ -13,8 +13,8 @@ require ( | |||
| github.com/mitchellh/mapstructure v1.2.3 | |||
| github.com/stretchr/testify v1.4.0 | |||
| github.com/urfave/cli/v2 v2.3.0 | |||
| github.com/vektah/gqlparser/v2 v2.3.1 | |||
| golang.org/x/tools v0.1.5 | |||
| github.com/vektah/gqlparser/v2 v2.3.2-0.20220228141359-a1885932a1bc | |||
giautm
reviewed
Feb 28, 2022
| } | ||
|
|
||
| """""" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed introspection to support the latest spec.
https://spec.graphql.org/October2021/#sec-Schema-Introspection
ref: vektah/gqlparser#182
This PR can avoid like this problem: #1636
Describe your PR and link to any relevant issues.
I have: