rename "example" dir to "_examples"

[frederikhors]

Should fix #1715.

I have:

• Added tests covering the bug / feature (see testing)
• Updated any relevant documentation (see docs)

[coveralls]

Coverage decreased (-0.01%) to 75.215% when pulling 956e6f5 on frederikhors:rename-example-dir-to-_examples into a054373 on 99designs:master.

[StevenACoffman]

So I think you also need to change the github actions and documentation to match to get the test failures to go away?

[frederikhors]

@StevenACoffman what this test fails?

--- FAIL: TestRewriter (0.11s)
    --- FAIL: TestRewriter/default (0.11s)
        rewriter_test.go:27: 
            	Error Trace:	rewriter_test.go:27
            	Error:      	"[]" should have 2 item(s), but has 0
            	Test:       	TestRewriter/default

[duckbrain]

@frederikhors It looks like internal/rewrite/rewriter_test.go should be reverted. It was referencing a file named example.go, which was not renamed (and is already in a directory named testdata, so it doesn't need to be).

[frederikhors]

@duckbrain done. What is the problem now?

@StevenACoffman can you please merge this as soon as we understand the remaining problem? I had to fix a lot of conflicts from the master branch.

[StevenACoffman]

Sure. If we can get it passing, I'd like to merge it sooner rather than later.

[frederikhors]

@StevenACoffman I do not understand what these 2 errors are.

[duckbrain]

The Lint/Lint one probably needs running go generate on each of the examples. Because of the rename, go generate ./... will no longer generate the examples, so you'll need to refer to them individually.

The integration/federation one is likely referring to an old path in start.sh. need to look into it more.

[frederikhors]

I fixed lint step.

Now only this is the problem:

I cannot understand the reason!

[mtibben]

.github/workflows/check-federation: line 7: ./start.sh: Permission denied

Were the permissions for start.sh changed? A chmod 755 start.sh should fix it

[frederikhors]

.github/workflows/check-federation: line 7: ./start.sh: Permission denied

Were the permissions for start.sh changed? A chmod 755 start.sh should fix it

Oh! Wow! I'm on Windows. Can you please chmod it?

[mtibben]

hmmm you should be able to use WSL?

[frederikhors]

hmmm you should be able to use WSL?

I'm not really in that things... 😢

[duckbrain]

@mtibben Good catch.

@frederikhors I don't use Windows, does git update-index --chmod=+x _examples/federation/start.sh do it?

Source https://www.scivision.dev/git-windows-chmod-executable/

[StevenACoffman]

I chmod'ed it for you.

[StevenACoffman]

One concern is that it is worth highlighting in the directions for contributing code how to run all these checks locally. When they fail, it's not obvious from the github action failures what the problem is.

[frederikhors]

Can we merge now?